On Mon, 06 Jun 2005 14:06:48 +0000
"Julio M. Merino Vidal" <jmmv84@xxxxxxxxx> wrote:
> >From a very quick review, I see:
> - Auxiliary functions are not static.
> - Inconsistent spacing: there are some commas with a space after them,
> while others don't have it; there are multiple operators without
> spaces around them while others have it; etc.
> See /usr/share/misc/style.
> - Functions that return values which are discarded should be prefixed
> with (void). I.e., (void)printf("blah");
> - Options in getopt should be sorted alphabetically.
> - Most NetBSD utilities don't have '-h' for help, while this one does.
> - Where are the patches to modify the build infrastructure to build the
> - And the manual page?
Attached is the patch with all your suggestions fixed, except the second
suggestion (inconsistent spacing in multiple operators), I leave them as is
because I think they are better to understand IMHO (der mouse said so
Note that the manpage might need a review (wiz, snj?).
Thank you to all for your comments.