tech-userlevel@netbsd.org
[Top] [All Lists]

Re: scan_ffs from OpenBSD ported and improved.

Subject: Re: scan_ffs from OpenBSD ported and improved.
From: Roland Illig
Date: Tue, 07 Jun 2005 06:36:24 +0200
Simon Burge wrote:
I've always thought that "(void)printf(..." was overkill.  In our source
tree, a quick grep shows 71520 printf's without void and 2203 with void.

I hope that in all the non-void cases ferror() is called after printing, but my guess is that it isn't.

For instance, I had problems with pkg_create(1), which doesn't check the list of file names passed to the tar(1) child process. It just dies without printing an error message. That makes detecting faults really difficult.

Roland

<Prev in Thread] Current Thread [Next in Thread>