tech-userlevel@netbsd.org
[Top] [All Lists]

Re: scan_ffs from OpenBSD ported and improved.

Subject: Re: scan_ffs from OpenBSD ported and improved.
From: Roland Illig
Date: Tue, 07 Jun 2005 09:49:53 +0200
David Laight wrote:
On Tue, Jun 07, 2005 at 06:36:24AM +0200, Roland Illig wrote:

Simon Burge wrote:

I've always thought that "(void)printf(..." was overkill.  In our source
tree, a quick grep shows 71520 printf's without void and 2203 with void.

I hope that in all the non-void cases ferror() is called after printing, but my guess is that it isn't.


You need to check ferror() after fflush(), not fprintf().

Good point. I should reread the <stdio.h> documentation. :)

Roland

<Prev in Thread] Current Thread [Next in Thread>