samba-technical@lists.samba.org
[Top] [All Lists]

Re: patch for changes in FLOCK calls.

Subject: Re: patch for changes in FLOCK calls.
From: Jeremy Allison
Date: Fri, 2 Oct 2009 10:05:38 -0700
On Fri, Oct 02, 2009 at 01:30:58PM +0200, Volker Lendecke wrote:
> On Thu, Oct 01, 2009 at 10:50:01AM +0530, Abhidnya P Chirmule wrote:
> > Please go through the below patch which changes FLOCK calls. Let me know
> > your views.
> > 
> > (See attached file: flock-vfs.patch)
> 
> Looks good to me. From looking at the source code, the VFS
> call FLOCK is used in Samba to set share modes. As those are
> influenced not only by the share mode itself, but also by
> the access mask, it is only valid to also pass that down.
> 
> Jeremy, what do you think?

I took a quick look over this and it seemed reasonable.

Jeremy.

<Prev in Thread] Current Thread [Next in Thread>