On Fri, 2009-09-11 at 09:07 +0000, Matthias Dieter WallnÃfer wrote:
> to be honest, I find my reworked version now very clear. We ask for
> the attributes where we need them. Sure, we'd have some small speedup
> (one lookup less) but if you consider the LDB modules - also they
> often have more lookups than really needed. More lookups generally
> means to be more clear in design.
> The other point is (like Andrew mentioned) that the design of this
> call still isn't completed fully yet. There is missing the
> "dNSDomainName" and "servicePrincipalName" handling (maybe some more
> checks, also the "samldb" module will be enhanced).
> So if you really want this patch in - please repost it after the final
I would still prefer one search. It means one set of error handling,
and clearer behaviour.
I don't see how pre-declaring the attributes we need, then asking for
them at the right moment is really that hard.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.