samba-technical@lists.samba.org
[Top] [All Lists]

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-

Subject: Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1567-g3fa6943
From: Volker Lendecke
Date: Tue, 12 May 2009 20:34:19 +0200
On Tue, May 12, 2009 at 12:08:47PM -0400, Derrell Lipman wrote:
> It looks like previously, extra_data could already contain some data which
> was then realloc'ed to add more space, whereas now you always overwrite
> extra_data each time. Is that correct? Is this potentially losing previously
> initialized data that needs to stick around?

If you look at the routines, you will see that the REALLOC
is actually an alloc. This realloc was the first time that
chunk was touched after the initial NULL assignment.

Please correct me if I'm wrong, but this was my impression
from reading the code.

Volker
<Prev in Thread] Current Thread [Next in Thread>