samba-technical@lists.samba.org
[Top] [All Lists]

Re: [PATCH]: Fix the bug tevent_req_poll() loops forever(was: [PATCH] (p

Subject: Re: [PATCH]: Fix the bug tevent_req_poll) loops forever(was: [PATCH] (partial) tevent_req_poll() loops for ever....
From: Volker Lendecke
Date: Sat, 16 May 2009 19:18:49 +0200
On Sun, May 17, 2009 at 12:47:13AM +0800, boyang wrote:
> boyang wrote:
> > Jeremy Allison wrote:
> >   
> >> Ok, I've reviewed this carefully (with some test code) and you're
> >> completely correct.
> >>
> >> We'll have to deal with this, I've talked to Volker and he has
> >> some ideas on how to deal with this efficiently.
> >>   
> >>     
> >
> >   
> Hi, everyone:
>      Can someone please have a look at this? If it looks ok, I'll push
> it to master. :-) Because there is change to struct cli_state, I need
> someone to comment on this to see if it has any side effect, or
> anything. :-)
>      Thanks!

There's no way to get around the special case in so many
places? Sooner or later someone will forget to set that
correctly.

Volker
<Prev in Thread] Current Thread [Next in Thread>