samba-technical@lists.samba.org
[Top] [All Lists]

[PATCH] s3: Fix chained sesssetupAndX/tconn messages

Subject: [PATCH] s3: Fix chained sesssetupAndX/tconn messages
From: Tim Prouty
Date: Wed, 6 May 2009 15:27:35 -0700
Volker (and any other chaining experts),

In master a sesssetupAndX chained with a tconn will not correctly set
the TID in the response header.  I'm seeing an XP client send this
chained sesssetup/tconn when samba has security = share.  Samba's
current behavior is to return a TID of 0 in the smb header rather than
the actual TID.  This patch also updates the UID in the header as
well.  I wanted to have someone who knows the chaining code well
review this before I push it.

I spent a bit of time working on a torture test to make it easier to
reproduce, but the infrastructure isn't quite there to easily chain
sesssetupAndX messages.  Since I don't have a test, I attached two
very small pcaps of the before and after to better show the bug.
Notice in the before pcap the response has a TID of 0.


<Prev in Thread] Current Thread [Next in Thread>