samba-technical@lists.samba.org
[Top] [All Lists]

Re: [PATCH] clean the event context after fork in fork_domain_child()

Subject: Re: [PATCH] clean the event context after fork in fork_domain_child()
From: boyang
Date: Wed, 07 Jan 2009 20:04:14 +0800
Stefan (metze) Metzmacher wrote:
> boyang schrieb:
>   
>> Jeremy Allison wrote:
>>     
>>> On Tue, Jan 06, 2009 at 01:19:41PM +0800, boyang wrote:
>>>   
>>>       
>>>> Jeremy Allison wrote:
>>>>     
>>>>         
>>> Ok, I've finished doing a lot of cleanup work on the
>>> event code in winbindd. It's all checked into 3.3 and
>>> master. Please review.
>>>
>>> If you feel it's working, feel free to back-port to 3.2
>>> and/or 3.0.x and I'll commit patches for you. I'm not
>>> doing that work yet as I'm not sure if we're doing any
>>> more 3.2.x releases or just moving on to 3.3.0.
>>>   
>>>       
>> Hi, Jeremy:
>>      Your patch is good. I have done some initial test on it. And I
>> think we can do some work more to clean the context.
>> 1*  _client_list or winbindd_client_list() is never used in child,
>> destroy and free it.
>> 2* file descriptors come from listen socket in parent, accepted socket
>> in parent, socket pairs in parent are never used, close it and delete is
>> from fd_events.
>> 3* delete all memory credentials too as newly forked child won't use it.
>> I did some initial test and it works.
>> Patches are in the attachment, please review it. Thanks!
>>     
>>> Jeremy.
>>>
>>>   
>>>       
>
> Why do you use the deprecated talloc_destroy() ?
>   
:-P  I didn't notice that talloc_destroy() is deprecated... Must we use
TALLOC_FREE() here?
> metze
>
>
>   

Attachment: boyang.vcf
Description: Vcard

<Prev in Thread] Current Thread [Next in Thread>