samba-technical@lists.samba.org
[Top] [All Lists]

Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8, and

Subject: Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8, and friends
From: Volker Lendecke
Date: Tue, 20 May 2008 23:19:10 +0200
On Mon, May 12, 2008 at 05:29:16PM -0700, Tim Prouty wrote:
> Here is the second round of fixes for the patch set we discussed that  
> cleans up the return values in charcnv.c.  This one fixes the callers  
> of convert_string_allocate as well as their callers.  This patch  
> turned out to be a bit larger then I wanted, but it was much cleaner  
> to just fix all callers at the same time.

Ok, it's in. Sorry it took so long, we're a bit busy for
release. I made your first one go into 3.2.0, but I think
this is a bit late. (It would have been late even if I had
reviewed it quicker... :-)

I had to add the proto changes manually, and you forgot one
call in vfs_catia.c. I just added that.

Thanks for that cleanup, keep them coming!

Volker
<Prev in Thread] Current Thread [Next in Thread>