samba-technical@lists.samba.org
[Top] [All Lists]

Re: [PATCH] Enable vfs objects = /full/path/to/object.so

Subject: Re: [PATCH] Enable vfs objects = /full/path/to/object.so
From: simo
Date: Sun, 28 Oct 2007 12:35:23 -0400
On Sun, 2007-10-28 at 12:10 -0400, simo wrote:
> On Sun, 2007-10-28 at 15:51 +0100, Volker Lendecke wrote:
> > On Sun, Oct 28, 2007 at 09:09:17AM -0400, simo wrote:
> > 
> > > > Right now I'm testing a vfs object. I can't right now in
> > > > make test, because "vfs objects" assumes the .so files
> > > > to be in $libdir/vfs. This patch parses the module name
> > > > out of the object name in case it starts with "/". The
> > > > module name is assumed to be the last path component's
> > > > basename.
> > > 
> > > Looks sane.
> > 
> > What about my question "author doesn't push, reviewer does"?
> > :-)
> 
> Oh, did we decide something like this?
> Let me try my skills with git then :)


Pushed.
Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo@xxxxxxxxx>
Senior Software Engineer at Red Hat Inc. <ssorce@xxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>