samba-technical@lists.samba.org
[Top] [All Lists]

Re: Bug in talloc_asprintf_append()

Subject: Re: Bug in talloc_asprintf_append()
From: Jeremy Allison
Date: Fri, 14 Sep 2007 10:05:50 -0700
On Fri, Sep 14, 2007 at 09:56:44AM -0700, Jeremy Allison wrote:
> On Fri, Sep 14, 2007 at 06:52:04PM +0200, Volker Lendecke wrote:
> > On Fri, Sep 14, 2007 at 09:45:20AM -0700, Jeremy Allison wrote:
> > > Can we leave this one as-is (least suprises) and add
> > > a function with a name that actually means what it
> > > does, that will do what you need ?
> > 
> > Well, feel free to change it to whatever you want, but
> > please keep the original functionality (no strlen calls).
> 
> Do you have existing uses of talloc_asprintf_append()
> that depend on no strlen calls ? Where are they ?
> 
> If I add talloc_asprintf_append_end() I'll need to
> change these calls to use the new name.

Just to check with Metze and Volker - are you happy
with talloc_asprintf_append_end() that has the old
behaviour.

I have a patch ready to commit that adds it.

Jeremy.

<Prev in Thread] Current Thread [Next in Thread>