samba-technical@lists.samba.org
[Top] [All Lists]

Re: Q about svn r20243

Subject: Re: Q about svn r20243
From: simo
Date: Fri, 25 May 2007 14:43:23 -0400
On Fri, 2007-05-25 at 13:39 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> simo wrote:
> > On Fri, 2007-05-25 at 13:09 -0500, Gerald (Jerry) Carter wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Simo,
> >>
> >> I know this was 5 months ago, but do you remember what use case
> >> prompted you to make this change ?
> >>
> >>    "Make lookup_name resolve both the mapped and the
> >>     real unix group name"
> > 
> > Sorry, I tried to look at the code as well, but I really can't remember
> > that specific commit or the reason why I did it.
> >>From the r20242 I can argue I was working on some problem resolving SIDs
> > for local groups.
> 
> 
> ok.  So let me ask this.  I understand that you wanted to be able to
> to be able to look up both the unix and ntgroup names in the group
> mapping tables.  But I'm pretty sure that we decided not to do
> this in the 3.0.23 changes and just require the mapped named
> in things like "valid users".
> 
> So my question is, "Do you still think your change is necessary?"
> it only exists in the SAMBA_3_0 tree btw.

Given the fact I can't remember why I did it, I suppose it was not so
important. The fact it is only in SAMBA_3_0 is indicative I didn't feel
comfortable putting it in the release branch for some reason.

So I'd say we can cut it out.

If it was something we really needed, it will resurface and next time I
hope I will give a better log message :/

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra@xxxxxxxxx
http://samba.org

<Prev in Thread] Current Thread [Next in Thread>