samba-technical@lists.samba.org
[Top] [All Lists]

Re: svn commit: samba r20655 - in branches/SAMBA_3_0_24/source: client i

Subject: Re: svn commit: samba r20655 - in branches/SAMBA_3_0_24/source: client include libsmb printing rpc_server smbd
From: Jeremy Allison
Date: Wed, 10 Jan 2007 11:15:22 -0800
On Wed, Jan 10, 2007 at 10:59:35AM -0800, James Peach wrote:
> >   branches/SAMBA_3_0_24/source/client/client.c
> >   branches/SAMBA_3_0_24/source/include/smb.h
> >   branches/SAMBA_3_0_24/source/include/smb_macros.h
> 
> ISDOT and ISDOTDOT are already defined in lib/replace/system/dir.h. Do  
> you really need them here?

They were already in smbd/dir.c

> Do you really mean "if (ISDOT(start))"? If ISDOT(start) is true, then  
> end is guaranteed to be '\0'.

Yes I think so

<Prev in Thread] Current Thread [Next in Thread>