samba-technical@lists.samba.org
[Top] [All Lists]

Move change_owner_to_parent from open_file_ntcreate to open_file?

Subject: Move change_owner_to_parent from open_file_ntcreate to open_file?
From: Volker Lendecke
Date: Sun, 17 Dec 2006 18:50:03 +0100
Hi, Jeremy!

Right now I'm trying to consolidate the use of
parent_dirname (which sucks ;-) a bit. Two users are
inherit_acls and change_owner_to_parent. The
open_file_ntcreate path calls parent_dirname potentially
twice, via both those callers.

As both inherit_acls change_owner_to_parent logically do
close things, would moving them together via the attached
disturb any code path I don't see? Open_file_fchmod (the
other user of open_file) should not be affected, as it will
never create the file.

What do you think?

Volker

Attachment: look
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>