samba-technical@lists.samba.org
[Top] [All Lists]

Re: [Fwd: Re: Samba 4 libnet_join and RPC-JOIN torture test]

Subject: Re: [Fwd: Re: Samba 4 libnet_join and RPC-JOIN torture test]
From: Andrew Bartlett
Date: Fri, 23 Sep 2005 23:24:58 +1000
On Fri, 2005-09-23 at 11:36 +0200, Stefan Metzmacher wrote:
> Am Montag, 19. September 2005 16:19 schrieb Brad Henry:
> > Hi metze, have you had a chance to look over this patch? Besides the
> > error handling, is there anything you think I need to do to make this
> > acceptable for Samba 4?
> Hi Brad, Hi Andrew,
> 
> that patch was quite good, but had a few little cut'n'paste bugs...
> 
> I have changed this:
> - a few typos
> - using talloc_steal(mem_ctx, ...) instead of talloc_steal(r, ...) because we
>    can't assume that mem_ctx and r are the same!

This was actually deliberate, it was intentional (for better coding
style) that the caller would need to make 'r' talloc()ed.  

> - make libnet_JoinADSDomain and libnet_JoinSite static
> - remove schema_dn_str and ntds_dn_str from JoinSite() becuase they're not
>   used yet.
> - remove white spaces and use tabs in the torture/ code
> 
> if you're both happy with this patch:
> Andrew: please to some RPC-JOIN tests and net join runtime tests, and commits 
> this patch

Yep, I'll test and get this in.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
<Prev in Thread] Current Thread [Next in Thread>