samba-cvs.cvs
[Top] [All Lists]

[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-3

Subject: [SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-32-150-g58331a1
From: Jeremy Allison
Date: Wed, 11 Feb 2009 16:11:44 -0600 CST
The branch, v3-0-test has been updated
       via  58331a118dd6a7fb56e70afe6cf93ef7cfff7e81 (commit)
      from  db4a435d235bedf48d668a0f4418dd46f38044ed (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test


- Log -----------------------------------------------------------------
commit 58331a118dd6a7fb56e70afe6cf93ef7cfff7e81
Author: Yasuma Takeda <yasuma@xxxxxxxxxxxxx>
Date:   Wed Feb 11 14:10:21 2009 -0800

    Fix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not 
work correctly with "security = domain"
    
    1. If DNS server is invalid, the get_sorted_dc_list() is called with
    realm(FQDN) and it fails.
    2. On the next step, the get_sorted_dc_list() is called with realm(FQDN) 
again.
    
    I think "again" is wrong place.
    On the 2nd step, get_sorted_dc_list() should be called with 
realm(WORKGROUP).

-----------------------------------------------------------------------

Summary of changes:
 source/libads/ldap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libads/ldap.c b/source/libads/ldap.c
index 36e8693..65f13cd 100644
--- a/source/libads/ldap.c
+++ b/source/libads/ldap.c
@@ -275,6 +275,8 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
        if (c_realm && *c_realm) 
                got_realm = True;
                   
+ again:
+
        /* we need to try once with the realm name and fallback to the 
           netbios domain name if we fail (if netbios has not been disabled */
           
@@ -326,8 +328,6 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
 
        sitename = sitename_fetch(realm);
 
- again:
-
        DEBUG(6,("ads_find_dc: (cldap) looking for %s '%s'\n",
                (got_realm ? "realm" : "domain"), realm));
 


-- 
Samba Shared Repository

<Prev in Thread] Current Thread [Next in Thread>
  • [SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-32-150-g58331a1, Jeremy Allison <=