samba-cvs.cvs
[Top] [All Lists]

Re: svn commit: samba r20253 - in branches/SAMBA_3_0/source/smbd: .

Subject: Re: svn commit: samba r20253 - in branches/SAMBA_3_0/source/smbd: .
From: Jeremy Allison
Date: Tue, 19 Dec 2006 09:48:17 -0800
On Tue, Dec 19, 2006 at 04:36:54PM +0000, vlendec@xxxxxxxxx wrote:
> Author: vlendec
> Date: 2006-12-19 16:36:54 +0000 (Tue, 19 Dec 2006)
> New Revision: 20253
> 
> WebSVN: 
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20253
> 
> Log:
> Reduce some code duplication, make reply_mkdir go through the same code paths
> ncreate does. This is a bit slower (about 10-20%), because it goes touches the
> share mode db, but I think not having to call change_owner_to_parent and
> friends in fewer places outweighs this. And, mkdir is not the way current
> Windows boxes create directories, they do it via the ncreate call.

If this passes the torture tests can you add it to SAMBA_3_0_24
as well please ? This is so obviously the correct way to do this
(and is the way Windows must do it :-) that I'm embarrassed for
not coding it that way in the first place :-).

Jeremy.

<Prev in Thread] Current Thread [Next in Thread>