samba-cvs.cvs
[Top] [All Lists]

svn commit: samba r15294 - in trunk/source/smbd: .

Subject: svn commit: samba r15294 - in trunk/source/smbd: .
From:
Date: Thu, 27 Apr 2006 13:42:24 +0000 GMT
Author: jra
Date: 2006-04-27 13:42:23 +0000 (Thu, 27 Apr 2006)
New Revision: 15294

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15294

Log:
Don't ever set O_SYNC on open unless "strict sync = yes".
This could be the cause of the perf. problem reported
between 3.0.14a and 3.0.2x. Lufthansa has *wireless*
on their flights to the USA now...  (I'm in heaven ! :-).
Jeremy.

Modified:
   trunk/source/smbd/open.c


Changeset:
Modified: trunk/source/smbd/open.c
===================================================================
--- trunk/source/smbd/open.c    2006-04-27 13:42:18 UTC (rev 15293)
+++ trunk/source/smbd/open.c    2006-04-27 13:42:23 UTC (rev 15294)
@@ -1308,7 +1308,7 @@
         */
 
 #if defined(O_SYNC)
-       if (create_options & FILE_WRITE_THROUGH) {
+       if (lp_strict_sync(SNUM(conn)) && (create_options & 
FILE_WRITE_THROUGH)) {
                flags2 |= O_SYNC;
        }
 #endif /* O_SYNC */

<Prev in Thread] Current Thread [Next in Thread>
  • svn commit: samba r15294 - in trunk/source/smbd: ., jra <=