samba-cvs.cvs
[Top] [All Lists]

svn commit: samba r13542 - in branches/SAMBA_3_0/source/passdb: .

Subject: svn commit: samba r13542 - in branches/SAMBA_3_0/source/passdb: .
From:
Date: Fri, 17 Feb 2006 15:51:25 +0000 GMT
Author: jra
Date: 2006-02-17 15:51:25 +0000 (Fri, 17 Feb 2006)
New Revision: 13542

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13542

Log:
Don't reuse a pointer we just freed (Doh!).
Jeremy.

Modified:
   branches/SAMBA_3_0/source/passdb/secrets.c


Changeset:
Modified: branches/SAMBA_3_0/source/passdb/secrets.c
===================================================================
--- branches/SAMBA_3_0/source/passdb/secrets.c  2006-02-17 13:30:34 UTC (rev 
13541)
+++ branches/SAMBA_3_0/source/passdb/secrets.c  2006-02-17 15:51:25 UTC (rev 
13542)
@@ -1051,6 +1051,8 @@
                                &pdc->domain);
 
        if (ret == -1 || l1 != 8 || l2 != 8 || l3 != 8 || l4 != 16 || l5 != 16) 
{
+               /* Bad record - delete it. */
+               tdb_delete_bystring(tdb_sc, keystr);
                talloc_free(keystr);
                talloc_free(pdc);
                SAFE_FREE(pseed_chal);
@@ -1059,8 +1061,6 @@
                SAFE_FREE(psess_key);
                SAFE_FREE(pmach_pw);
                SAFE_FREE(value.dptr);
-               /* Bad record - delete it. */
-               tdb_delete_bystring(tdb_sc, keystr);
                return False;
        }
 

<Prev in Thread] Current Thread [Next in Thread>
  • svn commit: samba r13542 - in branches/SAMBA_3_0/source/passdb: ., jra <=