samba-cvs.cvs
[Top] [All Lists]

svn commit: samba r13493 - branches/SAMBA_3_0/source/passdb trunk/source

Subject: svn commit: samba r13493 - branches/SAMBA_3_0/source/passdb trunk/source/passdb
From:
Date: Mon, 13 Feb 2006 16:48:24 +0000 GMT
Author: vlendec
Date: 2006-02-13 16:48:24 +0000 (Mon, 13 Feb 2006)
New Revision: 13493

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13493

Log:
module_name and module_location are the same string. Fix a valgrind
error.

Volker
Modified:
   branches/SAMBA_3_0/source/passdb/pdb_interface.c
   trunk/source/passdb/pdb_interface.c


Changeset:
Modified: branches/SAMBA_3_0/source/passdb/pdb_interface.c
===================================================================
--- branches/SAMBA_3_0/source/passdb/pdb_interface.c    2006-02-13 15:12:22 UTC 
(rev 13492)
+++ branches/SAMBA_3_0/source/passdb/pdb_interface.c    2006-02-13 16:48:24 UTC 
(rev 13493)
@@ -173,14 +173,16 @@
        }
 
        DEBUG(5,("Found pdb backend %s\n", module_name));
-       SAFE_FREE(module_name);
 
        if ( !NT_STATUS_IS_OK( nt_status = entry->init(methods, 
module_location) ) ) {
                DEBUG(0,("pdb backend %s did not correctly init (error was 
%s)\n", 
                        selected, nt_errstr(nt_status)));
+               SAFE_FREE(module_name);
                return nt_status;
        }
 
+       SAFE_FREE(module_name);
+
        DEBUG(5,("pdb backend %s has a valid init\n", selected));
 
        return nt_status;

Modified: trunk/source/passdb/pdb_interface.c
===================================================================
--- trunk/source/passdb/pdb_interface.c 2006-02-13 15:12:22 UTC (rev 13492)
+++ trunk/source/passdb/pdb_interface.c 2006-02-13 16:48:24 UTC (rev 13493)
@@ -174,14 +174,16 @@
        }
 
        DEBUG(5,("Found pdb backend %s\n", module_name));
-       SAFE_FREE(module_name);
 
        if ( !NT_STATUS_IS_OK( nt_status = entry->init(methods, 
module_location) ) ) {
                DEBUG(0,("pdb backend %s did not correctly init (error was 
%s)\n", 
                        selected, nt_errstr(nt_status)));
+               SAFE_FREE(module_name);
                return nt_status;
        }
 
+       SAFE_FREE(module_name);
+
        DEBUG(5,("pdb backend %s has a valid init\n", selected));
 
        return nt_status;

<Prev in Thread] Current Thread [Next in Thread>
  • svn commit: samba r13493 - branches/SAMBA_3_0/source/passdb trunk/source/passdb, vlendec <=