qemu-devel@nongnu.org
[Top] [All Lists]

Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fi

Subject: Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes
From: Luiz Capitulino
Date: Fri, 25 Sep 2009 13:26:44 -0300
On Fri, 25 Sep 2009 03:53:47 +0200
Markus Armbruster <armbru@xxxxxxxxxx> wrote:

> Markus Armbruster (6):
>   Fix pci_vga_init() not to ignore bus argument
>   Fix pci_add storage not to exit on bad first argument
>   Make it obvious that pci_nic_init() can't fail
>   Fix pci_add nic not to exit on bad model
>   pci_create() is now unused, remove it
>   Rename pci_create_noinit() to pci_create()

 The Right Thing :) and it (obviously) fixes the problem with
pci_add for me.

 The only nitpick is that by passing an invalid NIC on command
line would make qemu dump valid NIC models.. But not an issue,
anyway.


<Prev in Thread] Current Thread [Next in Thread>