qemu-devel@nongnu.org
[Top] [All Lists]

Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fi

Subject: Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes
From: Markus Armbruster
Date: Mon, 28 Sep 2009 21:14:45 +0200
Mark McLoughlin <markmc@xxxxxxxxxx> writes:

> On Mon, 2009-09-28 at 17:05 +0100, Mark McLoughlin wrote:
>> On Fri, 2009-09-25 at 03:53 +0200, Markus Armbruster wrote:
>> > Markus Armbruster (6):
>> >   Fix pci_vga_init() not to ignore bus argument
>> >   Fix pci_add storage not to exit on bad first argument
>> >   Make it obvious that pci_nic_init() can't fail
>> >   Fix pci_add nic not to exit on bad model
>> >   pci_create() is now unused, remove it
>> >   Rename pci_create_noinit() to pci_create()
>> 
>> Looks like a good series to me too
>> 
>> Acked-by: Mark McLoughlin <markmc@xxxxxxxxxx>
>
> Oh, and IMHO, at least patches 3 and 4 makes sense for stable-0.11;
> patch 4 just needs an update for e1000 being the default model now
>
> Patch 2 might make sense too with a little massaging

Yes.  The others are mere cleanup, doubt they're appropriate for stable.


<Prev in Thread] Current Thread [Next in Thread>