Blue Swirl <blauwirbel@xxxxxxxxx> wrote:
> On Wed, Sep 23, 2009 at 7:09 PM, Markus Armbruster <armbru@xxxxxxxxxx> wrote:
>> Laurent Desnogues <laurent.desnogues@xxxxxxxxx> writes:
>>> On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela <quintela@xxxxxxxxxx> wrote:
>>>> ANSI c89 has been with us for a while.
>>>> Signed-off-by: Juan Quintela <quintela@xxxxxxxxxx>
>>>> Âconfigure | Â Â1 +
>>>> Â1 files changed, 1 insertions(+), 0 deletions(-)
>>>> diff --git a/configure b/configure
>>>> index 62dccd2..81b9ba8 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -1648,6 +1648,7 @@ if test "$debug" = "no" ; then
>>>> ÂQEMU_CFLAGS="-Wall -Wundef -Wendif-labels -Wwrite-strings
>>>> -Wmissing-prototypes $QEMU_CFLAGS"
>>>> ÂQEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
>>>> +QEMU_CFLAGS="-Wold-style-declaration -Wold-style-definition $QEMU_CFLAGS"
>>> Some older versions of gcc don't handle -Wold-style-declaration.
>>> For instance gcc 4.1.2.
>> Pretty old, do we want to support it? ÂIf yes, make configure detect
>> whether the warning works?
> Yes, OpenBSD uses 3.3.5 (propolice).
> There are already similar checks for linker flags in configure, new
> checks for warnings available would allow a different set of flags for
> the latest and greatest GCC and the good old ones.
Fixed in new series just sent. It detects in configure if flags exists.
Thanks for the review, Juan.