|Subject:||Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic|
|Date:||Tue, 09 Jun 2009 17:51:20 +0200|
On 06/09/09 17:32, Paul Brook wrote:
On Tuesday 09 June 2009, Gerd Hoffmann wrote:On 06/09/09 17:01, Paul Brook wrote:+ qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);This should be using sysbus_init_irq. PaulPatch 3/3 kills that line anyway ...It's still wrong.
Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?What is the point in maintaining qemu_irqs in SysBusDevice directly and ignoring the qemu_irqs in DeviceState (aka SysBusDevice.qdev)?
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||[Qemu-devel] Re: [PATCH 6/7] virtio-net: Add new RX filter controls, Jan Kiszka|
|Next by Date:||Re: [Qemu-devel] [PATCH 2/3] Add pci_bus_reset() function., Gleb Natapov|
|Previous by Thread:||Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic, Paul Brook|
|Next by Thread:||Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic, Paul Brook|
|Indexes:||[Date] [Thread] [Top] [All Lists]|