Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic

[Gerd Hoffmann]

On 06/09/09 17:32, Paul Brook wrote:
> On Tuesday 09 June 2009, Gerd Hoffmann wrote:
> > On 06/09/09 17:01, Paul Brook wrote:
> > > > +    qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);
> > > This should be using sysbus_init_irq.
> > >
> > > Paul
> > Patch 3/3 kills that line anyway ...
>
> It's still wrong.

Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?

What is the point in maintaining qemu_irqs in SysBusDevice directly and 
ignoring the qemu_irqs in DeviceState (aka SysBusDevice.qdev)?

cheers,
  Gerd