qemu-devel@nongnu.org
[Top] [All Lists]

Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand

Subject: Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand
From: Paul Brook
Date: Thu, 5 Jun 2008 02:26:42 +0100
[foreach_cpu]
> > I tend to dislike such macros...
>
> Why?

I agree with Fabrice in this case. Iterating over all cpus isn't a 
particularly onerous task to start with. Using bizarre macros means that the 
code no longer looks like normal C.

> My debugger SMP fix already comes with 5 more use cases.

I'm unconvinced by SMP debugger support. FSF gdb isn't currently capable of 
handling SMP targets, so whatever you're doing is likely to be an ugly hack.

Paul


<Prev in Thread] Current Thread [Next in Thread>