qemu-devel@nongnu.org
[Top] [All Lists]

Re: [Qemu-devel] [PATCH] Merge NBD client/server int qemu-nbd

Subject: Re: [Qemu-devel] [PATCH] Merge NBD client/server int qemu-nbd
From: Avi Kivity
Date: Fri, 13 Jun 2008 21:09:17 +0300
Anthony Liguori wrote:

# qemu-nbd --disconnect /dev/nbd0

Regards,
Laurent
  +static void show_parts(const char *device)
+{
+    if (fork() == 0) {
+        int nbd;
+
+    /* wait device */
+        sleep(1);

This looks like a big red-herring. What is this sleep waiting for any can it be possibly made into something less racy?

It's called udevsettle, if the host is running udev.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.



<Prev in Thread] Current Thread [Next in Thread>