perl.cvs.parrot
[Top] [All Lists]

[svn:parrot] r29066 - branches/reautoicu/config/auto

Subject: [svn:parrot] r29066 - branches/reautoicu/config/auto
From:
Date: Fri, 4 Jul 2008 18:22:23 -0700 PDT
Newsgroups: perl.cvs.parrot

Author: jkeenan
Date: Fri Jul  4 18:22:22 2008
New Revision: 29066

Modified:
   branches/reautoicu/config/auto/icu.pm

Log:
[configure] Fix bug:  ( ( $arg->{ret} >> 8 ) != 0 ) in
_handle_search_for_icu_config() was one bit-shifting too many.  Value of
$arg->{ret} is assigned by Parrot::Configure::Utils::capture_output call which
*internally* big-shifts the return value of a system call.


Modified: branches/reautoicu/config/auto/icu.pm
==============================================================================
--- branches/reautoicu/config/auto/icu.pm       (original)
+++ branches/reautoicu/config/auto/icu.pm       Fri Jul  4 18:22:22 2008
@@ -216,17 +216,14 @@
    --icuheaders=(path)  Location of ICU headers without /unicode
    --icushared=(flags)  Full linker command to create shared libraries
 HELP
+#/
     return $die;
 }
 
 sub _handle_search_for_icu_config {
     my $self = shift;
     my $arg = shift;
-    if (
-        ( $arg->{ret} == -1 )
-            ||
-        ( ( $arg->{ret} >> 8 ) != 0 )
-    ) {
+    if ( $arg->{ret} ) {
         undef $arg->{icuconfig};
         $arg->{autodetect} = 0;
         $arg->{without}    = 1;

<Prev in Thread] Current Thread [Next in Thread>
  • [svn:parrot] r29066 - branches/reautoicu/config/auto, jkeenan <=