[email protected]
[Top] [All Lists]

PERFORCE change 114934 for review

Subject: PERFORCE change 114934 for review
From: Sam Leffler
Date: Fri, 23 Feb 2007 23:58:01 GMT
http://perforce.freebsd.org/chv.cgi?CH=114934

Change 114934 by [email protected]_ebb on 2007/02/23 23:57:19

        Correct refcnt handling for sending a null data frame; looks
        to have been mis-merged a while ago.

Affected files ...

.. //depot/projects/wifi/sys/net80211/ieee80211_output.c#65 edit

Differences ...

==== //depot/projects/wifi/sys/net80211/ieee80211_output.c#65 (text+ko) ====

@@ -339,6 +339,10 @@
 
 /*
  * Send a null data frame to the specified node.
+ *
+ * NB: the caller is assumed to have setup a node reference
+ *     for use; this is necessary to deal with a race condition
+ *     when probing for inactive stations.
  */
 int
 ieee80211_send_nulldata(struct ieee80211_node *ni)
@@ -351,10 +355,11 @@
        MGETHDR(m, M_NOWAIT, MT_DATA);
        if (m == NULL) {
                /* XXX debug msg */
+               ieee80211_unref_node(&ni);
                ic->ic_stats.is_tx_nobuf++;
                return ENOMEM;
        }
-       m->m_pkthdr.rcvif = (void *) ieee80211_ref_node(ni);
+       m->m_pkthdr.rcvif = (void *) ni;
 
        wh = mtod(m, struct ieee80211_frame *);
        ieee80211_send_setup(ic, ni, wh,
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/p4-projects
To unsubscribe, send any mail to "[email protected]"

<Prev in Thread] Current Thread [Next in Thread>
  • PERFORCE change 114934 for review, Sam Leffler <=