netbsd-bugs@netbsd.org
[Top] [All Lists]

Re: kern/40586: rgephy(4) now selects incorrect speed for some re(4)

Subject: Re: kern/40586: rgephy4) now selects incorrect speed for some re(4
From: Izumi Tsutsui
Date: Wed, 11 Feb 2009 01:35:19 UTC
Newsgroups: fa.netbsd.bugs

The following reply was made to PR kern/40586; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui@xxxxxxxxxxxxxxx>
To: Christoph_Egger@xxxxxx
Cc: gnats-bugs@xxxxxxxxxx, kern-bug-people@xxxxxxxxxx, gnats-admin@xxxxxxxxxx,
        netbsd-bugs@xxxxxxxxxx, tsutsui@xxxxxxxxxxxxxxx
Subject: Re: kern/40586: rgephy(4) now selects incorrect speed for some re(4)
Date: Wed, 11 Feb 2009 10:30:40 +0900

 Christoph_Egger@xxxxxx wrote:
 
 > I'm using rgephy(4) on nfe(4) and I can't reproduce
 > the problem. Maybe rgephy.c triggers a bug in re(4) now ?
 
 It's a quite bad idea to blindly "sync" sources without tests
 or proper analysis. As you can see in cvs logs, you just reverted
 some our local changes that were there since our initial revision.
 
 Please back it out and confirm which change actually improves
 your (rev 3 only?) hardware.  Functional changes and cosmetic ones
 should not be mixed as commit guideline says.
 ---
 Izumi Tsutsui
 

<Prev in Thread] Current Thread [Next in Thread>