Re: kern/36673 dubious code is sysmon_envsys

[YAMAMOTO Takashi]

The following reply was made to PR kern/36673; it has been noted by GNATS.

From: yamt@xxxxxxxxxxxxxxxxx (YAMAMOTO Takashi)
To: juan@xxxxxxxxxxx
Cc: gnats-bugs@xxxxxxxxxx
Subject: Re: kern/36673 (dubious code is sysmon_envsys)
Date: Tue, 24 Jul 2007 08:16:33 +0900 (JST)

 > On Tue, 24 Jul 2007 07:55:24 +0900 (JST)
 > yamt@xxxxxxxxxxxxxxxxx (YAMAMOTO Takashi) wrote:
 > 
 > > are you asking how it isn't clear?
 > 
 > I wanted to know what parts are wrong or how they can be improved.
 
 the usages of these mutexes are not obvious or documented.
 
 for example,
 - i can't understand why sysmon_envsys_createplist acquires
  sme_mtx in the loop.
 - sysmon_envsys_register seems to assume sysmon_envsys_list is stable
  while unlocking sme_list_mtx.
 
 YAMAMOTO Takashi