netbsd-bugs@netbsd.org
[Top] [All Lists]

Re: kern/36673 (dubious code is sysmon_envsys)

Subject: Re: kern/36673 dubious code is sysmon_envsys
From: YAMAMOTO Takashi
Date: Mon, 23 Jul 2007 10:59:46 +0900 JST
> Synopsis: dubious code is sysmon_envsys
> 
> State-Changed-From-To: feedback->closed
> State-Changed-By: xtraeme@xxxxxxxxxx
> State-Changed-When: Sun, 22 Jul 2007 18:18:27 +0000
> State-Changed-Why:
> I just fixed your last point, thanks for your PR.

please re-open.
can you re-read the PR and code by yourself before closing it?  thanks.

>         - what global mutexes like sme_mtx protect is not clear.

>         - sysmon_envsys_createplist seems to ignore most errors
>          unless it was for the last sensor in sme_sensor_data[].
>          i don't understand why the last one is special.

YAMAMOTO Takashi

<Prev in Thread] Current Thread [Next in Thread>