On Wednesday 30 June 2010 16:55:38 Mark Sapiro wrote:
> I looked at your patch yesterday. It seems good, but it's missing a
> critical piece. It has to increment DATA_FILE_VERSION in
> Mailman/Version.py. Otherwise, the code in Mailman/versions.py to add
> the include_sender_header attribute to existing lists will not be
> called. See the CheckVersion() method in Mailman/MailList.py.
Ah, sorry, seems like I was too quick with my merge proposal. Gnn, now I
have to grok how to supersede it on lp. I'll go and fix it.
> I don't have a problem with including the patch in 2.1, except for the
> ALLOW_SENDER_OVERRIDES = Yes
> If it were no, the feature would be entirely transparent to those who
> didn't want it, essentially preserving the current situation for those
> who took no action.
Hmm. The change is still fairly transparent I think, after an upgrade
there will just pop up an additional option for the list admins,
defaulting to the old value. In the worst case it (theoretically) allows
the list admin to shoot himself or his users in the foot. But nothing the
superadmin should be worried about (IMHO).
> The problem with that is all those cPanel and service provider list
> owners who would then not have access to the feature even if they were
> aware and wanted it, so I think the default needs to be Yes which is
> somewhat disruptive, but probably not excessively so considering the
> potential benefit.
As I am one of those cPanel users, trying to push this change down my
sysadmins throat the long way round, I'm in favor for Yes :)
Mailman-Developers mailing list
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9