linux.kernel
[Top] [All Lists]

Re: Papouch USB thermometer support

Subject: Re: Papouch USB thermometer support
From: Greg KH
Date: Fri, 31 Mar 2006 22:10:16 +0200
Newsgroups: linux.kernel
On Fri, Mar 24, 2006 at 08:46:55PM +0100, Folkert van Heusden wrote:
> Hi,
> 
> The following patch against 2.6.15 adds support for the www.Papouch.com
> USB thermometer by adding the appropriate vendor and product id.
> 
> 
> Signed off: Folkert van Heusden <folkert@xxxxxxxxxxxxxx

It should be "Signed-off-by:".

> diff -uNrbBd old/ftdi_sio.c new/ftdi_sio.c
> --- old/ftdi_sio.c      2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.c      2006-03-24 20:33:20.000000000 +0100

Can you make it so I can apply the patch from the root of the kernel
tree?  Documentation/SubmittingPatches describes how to create a patch
in this way.

> @@ -307,6 +307,7 @@
> 
> 
>  static struct usb_device_id id_table_combined [] = {
> +       { USB_DEVICE(PAPOUCHE_VENDOR, PAPOUCHE_THEM_PROD) },
>         { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },

Your email client ate the tabs :(

>         { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
>         { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -uNrbBd old/ftdi_sio.h new/ftdi_sio.h
> --- old/ftdi_sio.h      2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.h      2006-03-24 20:37:35.000000000 +0100
> @@ -20,8 +20,13 @@
>   * Philipp G?hring - pg@xxxxxxxxxxxxx - added the Device ID of the USB relais
>   * from Rudolf Gugler
>   *
> + * Folkert van Heusden - folkert@xxxxxxxxxxxxxx - added the device id of the
> + * temperature sensor from www.papouch.com

This information doesn't belong in the file, only in the changelog.
It's not needed.

Care to redo this?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at                                  www.tux.org/lkml/">http://www.tux.org/lkml/

<Prev in Thread] Current Thread [Next in Thread>
Privacy Policy