linux.debian.devel.mentors
[Top] [All Lists]

Re: RFS: wmnetselect (updated package, QA upload, RC bugfix)

Subject: Re: RFS: wmnetselect (updated package, QA upload, RC bugfix)
From: Frank Lichtenheld <djpig@xxxxxxxxxx>
Date: Mon, 28 Jul 2008 04:10:09 +0200
Newsgroups: linux.debian.devel.mentors, linux.debian.devel.qa

On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
> It builds these binary packages:
> wmnetselect - enhanced Iceweasel launch button designed for WindowMaker
> 
> The package appears to be lintian clean.
> 
> I'm not really happy about direct upstream code modification, but
> didn't want to introduce a patch system so I've just modified the
> manpage to replace Netscape/Mozilla with Iceweasel/Iceape.
> 
> The upload would fix these bugs: 419932

I think you will need some code fixes, too...

e.g.
$ rgrep mozilla . | head -n 3
./wmnetselect.c:/* default executable is mozilla, may be overridden by command 
line parameter */
./wmnetselect.c:#define EXECUTABLE "mozilla"
./wmnetselect.c:    "                         Defaults to mozilla",

Also you will need to verify that this does actually something useful
afterwards.

I actually skipped this package because I thought this wasn't worth the
effort.

Gruesse,
-- 
Frank Lichtenheld <djpig@xxxxxxxxxx>
www: http://www.djpig.de/


-- 
To UNSUBSCRIBE, email to debian-mentors-REQUEST@xxxxxxxxxxxxxxxx
with a subject of "unsubscribe". Trouble? Contact listmaster@xxxxxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>