kde-core-devel@kde.org
[Top] [All Lists]

Re: Review Request: Add support for AlphaChannel to KColorDialog

Subject: Re: Review Request: Add support for AlphaChannel to KColorDialog
From: "Christoph Feck"
Date: Tue, 13 Apr 2010 20:22:25 -0000

> On 2010-04-13 06:23:09, Johannes Christenson wrote:
> > I can't see any reason to treat the alpha channel different from other 
> > channels?

Can you clarify? Behavior that you see vs. expected behavior?


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3566/#review4996
-----------------------------------------------------------


On 2010-04-11 20:15:26, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3566/
> -----------------------------------------------------------
> 
> (Updated 2010-04-11 20:15:26)
> 
> 
> Review request for Gwenview, kdelibs and usability.
> 
> 
> Summary
> -------
> 
> Add an "alphaChannelEnabled" property to KColorDialog to support 
> QColorDialog::ShowAlphaChannel.
> Requires the patch from http://reviewboard.kde.org/r/3565 to show the alpha 
> gradient.
> 
> Please comment on:
> * name/description of newly added methods in KColorDialog
> * visible "Alpha" label ("Opacity"?)
> * placement of widgets (yes, Alpha label should be aligned to RGB labels, but 
> how?)
> 
> 
> Diffs
> -----
> 
>   
> /trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde.cpp
>  1113711 
>   /trunk/KDE/kdelibs/kdeui/colors/kcolordialog.h 1113786 
>   /trunk/KDE/kdelibs/kdeui/colors/kcolordialog.cpp 1113786 
> 
> Diff: http://reviewboard.kde.org/r/3566/diff
> 
> 
> Testing
> -------
> 
> I used this to test integration with QColorDialog:
> 
> #include <QtGui/QApplication>
> #include <QtGui/QColorDialog>
> #include <QtCore/QDebug>
> 
> int main(int argc, char *argv[])
> {
>     QApplication app(argc, argv);
>     QColor color = QColorDialog::getColor(QColor(255, 0, 0, 100), 0, "Select 
> ARGB Color",
>                                           QColorDialog::ShowAlphaChannel);
>     qDebug() << color;
> }
> 
> 
> Screenshots
> -----------
> 
> KColorDialog with enabled AlphaChannel
>   http://reviewboard.kde.org/r/3566/s/354/
> 
> 
> Thanks,
> 
> Christoph
> 
>

<Prev in Thread] Current Thread [Next in Thread>