|
|
> On 2010-03-29 10:05:15, David Faure wrote:
> > /trunk/KDE/kdelibs/kio/kio/kfileitemactions.cpp, line 583
> > <http://reviewboard.kde.org/r/3163/diff/1/?file=20421#file20421line583>
> >
> > KMimeTypeTrader has a preferredService method for this kind of use, no
> > need to use query+first.
>
> Todd wrote:
> What happens if I called storageID on an invalid (Ptr==0) service? Do I
> get an empty QString or does it cause and error or something else entirely?
>
> David Faure wrote:
> A Ptr is a pointer. You shouldn't call methods on a null Ptr, it will
> crash. So you need to test for null-ness first; just like you're currently
> testing for empty itemOffers list.
The reason I used query is because preferredService does not have have an
option for traderconstraint, which is used extensively here. So I think I need
to use query, right?
- Todd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3163/#review4731
-----------------------------------------------------------
On 2010-03-06 21:48:09, Todd wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3163/
> -----------------------------------------------------------
>
> (Updated 2010-03-06 21:48:09)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> When files are selected in the file browser and the right-click menu is
> opened, adds an option above the "Open with..." sub-menu to open all the
> files in their respective preferred applications. If all files have the same
> preferred application, it says "Open with <application>" and uses that
> application's icon, otherwise it just uses says "Open" and does not have an
> icon.
>
> This is similar to the behavior in dolphin where selecting multiple files and
> hitting "enter" opens those files in the preferred application. In order to
> maintain consistency, this patch also changes Dolphin to use the same slot as
> as the file manager right-click menu. The old Dolphin implementation just
> iterated through the list of files, opening each one in its default
> application. It did not have any way to deal with multiple files having the
> same default application.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/apps/dolphin/src/dolphincontroller.h 1080351
> /trunk/KDE/kdebase/apps/dolphin/src/dolphincontroller.cpp 1080351
> /trunk/KDE/kdelibs/kio/kio/kfileitemactions.h 1094205
> /trunk/KDE/kdelibs/kio/kio/kfileitemactions.cpp 1094205
> /trunk/KDE/kdelibs/kio/kio/kfileitemactions_p.h 1094205
>
> Diff: http://reviewboard.kde.org/r/3163/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Todd
>
>
|
|