kde-core-devel@kde.org
[Top] [All Lists]

Re: Review Request: Update KFileItem and KFileMetaPropsPlugin to only re

Subject: Re: Review Request: Update KFileItem and KFileMetaPropsPlugin to only request limited metaData avoid reading all the file and blocking the UI
From: DarÃo AndrÃs
Date: Wed, 24 Mar 2010 21:03:40 -0000
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3325/
-----------------------------------------------------------

(Updated 2010-03-24 21:03:40.024582)


Review request for kdelibs, Peter Penz, Nick Shaforostoff, David Faure, and 
vandenoever.


Changes
-------

Added Jos to the CC


Summary
-------

Backstory:
- KFileMetaInfo::What modes are not honored because they are unimplemented with 
Strigi (not really important in this case)
- KFileMetaInfo default What value is "Everything"
- Nick Shaforostoff (Lokalize maintainer) changed the default behavior of 
KFileMetaInfo to read the whole file when What is "Everything" (previously, it 
only read the first 64kb). This 64kb limit needs to be broken for 
metainformation to be fetched from .po files.

So, currently the file properties dialog (and every other impl using 
KFileItem::metaInfo()) will read the whole content of the file , blocking the 
UI with big files

My patch sets both implementations to use "KFileMetaInfo::TechnicalInfo | 
KFileMetaInfo::ContentInfo" instead of the default Everything (in any case, as 
those flags are not implemented, anything different to Everything would work)

Peter already plains to solve this in the File Properties dialog with his own 
threading method, but this patch covers the other situations (they are 
complementary fixes)

Things to discuss:
- If we choose my implementation we should probably state it on KFileInfo 
apidox ("metaInfo defaults to X, Z. Query your own KFileMetaInfo if you need 
more")
- Should we preserve the KFileMetaInfo::What flag (and implement it on a future 
using Strigi); or should the flag be removed and another flag added (something 
like ScanAllTheFile, ScanTheFirstKBs) ?
- Should we default to reading only the first 64kb of every file (as the 
previous approach) and introduce a new value of the flag "EverythingAllTheFile" 
(seems redundant) for Nick to use on Lokalize ?

References:
Nick original patch: http://reviewboard.kde.org/r/2215/
Peter threaded implementation: http://reviewboard.kde.org/r/3277/


This addresses bug 216932.
    https://bugs.kde.org/show_bug.cgi?id=216932


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kfile/kmetaprops.cpp 
1105269 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kio/kfileitem.cpp 
1105269 

Diff: http://reviewboard.kde.org/r/3325/diff


Testing
-------

Dolphin doesn't block when accessing the file properties dialog of a big 
(~400mb) file


Thanks,

DarÃo

<Prev in Thread] Current Thread [Next in Thread>