kde-core-devel@kde.org
[Top] [All Lists]

Re: [patch] KProtocolManager (kio/kio) extensions for application-specif

Subject: Re: [patch] KProtocolManager (kio/kio) extensions for application-specific user agent string
From: David Faure
Date: Wed, 6 Feb 2008 15:21:12 +0100
On Wednesday 06 February 2008, JarosÅaw Staniek wrote:
> 
> Hello
> For review;
> 
> - only adds 'X11' bit for 'p' key in "static QString 
> KProtocolManager::defaultUserAgent(const QString &keys)" for X11-based targets
> 
> - adds
>   static QString KProtocolManager::userAgentForApplication(
>      const QString &appName,
>      const QString& appVersion, const QStringList& extraInfo = QStringList() 
> );
>   for the application's user-agent string other than web browser (think of
>   KMail/KNode/Mailody..)
> 
> - adds static bool getSystemNameVersionAndMachine(
>       QString& systemName, QString& systemVersion, QString& machine );
>    (returns nicely splitted system name, version and machine type, for example
>    "Windows", "5.1", "i686"; also more useful for various sysinfo reporting)

Looks good to me.

-- 
David Faure, faure@xxxxxxx, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

<Prev in Thread] Current Thread [Next in Thread>