kde-core-devel@kde.org
[Top] [All Lists]

Re: Suspicous code in kdelibs-3.5.2

Subject: Re: Suspicous code in kdelibs-3.5.2
From: Michael Brade
Date: Wed, 5 Apr 2006 19:12:21 +0200
On Wednesday 05 April 2006 16:26, Christoph Bartoschek wrote:
> -----------------------------------------------------------------
> Lines where boolean expressions are used in non-boolean contexts:
> -----------------------------------------------------------------
>
> - kio/kio/kdirlister.cpp:947
> - kio/kio/kdirlister.cpp:1524
I don't quite understand... what's wrong with this:

  bool delayedMimeTypes = true;
  for ( KDirLister *kdl = listers->first(); kdl; kdl = listers->next() )
    delayedMimeTypes &= kdl->d->delayedMimeTypes;

kdl->d->delayedMimeTypes is a bool as well. Any ideas?

Thanks,
-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  °--web: http://www.kde.org/people/michaelb.html

KDE 4: Beyond Your Expectations
<Prev in Thread] Current Thread [Next in Thread>