kandula-dev@ws.apache.org
[Top] [All Lists]

Re: Kandula_1 ba patch 5(a)

Subject: Re: Kandula_1 ba patch 5a
From: Dasarath Weeratunge
Date: Mon, 18 Jun 2007 16:19:47 -0400
Quoting Hannes Erven <hannes@xxxxxxxx>:

> Hi Dasarath,
> 
> 
> >     [javac] symbol  : constructor IllegalArgumentException
> (java.lang.String,org
> > .apache.axis.AxisFault)
> 
> That's a rather strange thing: did you compile on java 1.4 ? Although 

Yes.

> I've set the source level to 1.4, my 5SE and 6SE compilers do not
> complain about this call. However the Javadoc for the 
> IllegalArgumentException constructors states that this method was 
> introduced in 1.5, so the compilers should complain...
> 
> Could you please change line 269 in the 
> ba.participant.AbstractParticipant to
> 
>       throw new RuntimeException(
> 
> (RuntimeException instead of IllegalArgumentException) ? That 
> constructor was introduced in 1.4. so it should be fine to use it.

Its OK now.

What's next? I suppose I have now checked in all the code.
I know that there was another patch on sample code-- and a big one too:(

How about completing the docs on the website and I'll let you do the rest 
yourself:-)

Thanks and well done!
--dasarath

> 
> 
> 
> Sorry for the inconvenience, I assumed it to be safe to set the source 
> compliance down to ensure 1.4 compatibility...
> 
> 
> Thanks & best regards,
> 
>       -hannes
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: kandula-dev-unsubscribe@xxxxxxxxxxxxx
> For additional commands, e-mail: kandula-dev-help@xxxxxxxxxxxxx
> 
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: kandula-dev-unsubscribe@xxxxxxxxxxxxx
For additional commands, e-mail: kandula-dev-help@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>