gnu.emacs.bug
[Top] [All Lists]

bug#4554: marked as done (local variable for updating the time stamp on

Subject: bug#4554: marked as done local variable for updating the time stamp on save
From: Emacs bug Tracking System
Date: Fri, 25 Sep 2009 22:15:05 +0000
Newsgroups: gnu.emacs.bug
Your message dated Fri, 25 Sep 2009 18:05:04 -0400
with message-id <87eipuistr.fsf@xxxxxxxxxxxxxxxxx>
and subject line Re: bug#4554: local variable for updating the time stamp on 
save
has caused the Emacs bug report #4554,
regarding local variable for updating the time stamp on save
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@xxxxxxxxxxxxxxxxxxxxxxxxxx
immediately.)


-- 
4554: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4554
Emacs Bug Tracking System
Contact owner@xxxxxxxxxxxxxxxxxxxxxxxxxx with problems
--- Begin Message ---
Subject: local variable for updating the time stamp on save
From: Juri Linkov
Date: Thu, 24 Sep 2009 23:51:23 +0300
The defcustom `safe-local-eval-forms' contains

    '((add-hook 'write-file-hooks 'time-stamp))

but the documentation suggests using

    (add-hook 'before-save-hook 'time-stamp)

This patch adds the recommended form to `safe-local-eval-forms' as well:

Index: lisp/files.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/files.el,v
retrieving revision 1.1083
diff -c -r1.1083 files.el
*** lisp/files.el       21 Sep 2009 22:12:30 -0000      1.1083
--- lisp/files.el       24 Sep 2009 20:47:28 -0000
***************
*** 2687,2693 ****
    :group 'find-file
    :type 'alist)
  
! (defcustom safe-local-eval-forms '((add-hook 'write-file-hooks 'time-stamp))
    "Expressions that are considered safe in an `eval:' local variable.
  Add expressions to this list if you want Emacs to evaluate them, when
  they appear in an `eval' local variable specification, without first
--- 2687,2695 ----
    :group 'find-file
    :type 'alist)
  
! (defcustom safe-local-eval-forms
!   '((add-hook 'before-save-hook 'time-stamp)
!     (add-hook 'write-file-hooks 'time-stamp))
    "Expressions that are considered safe in an `eval:' local variable.
  Add expressions to this list if you want Emacs to evaluate them, when
  they appear in an `eval' local variable specification, without first

-- 
Juri Linkov
http://www.jurta.org/emacs/



--- End Message ---
--- Begin Message ---
Subject: Re: bug#4554: local variable for updating the time stamp on save
From: Chong Yidong
Date: Fri, 25 Sep 2009 18:05:04 -0400
> > The defcustom `safe-local-eval-forms' contains
> >     '((add-hook 'write-file-hooks 'time-stamp))
> > but the documentation suggests using
> >     (add-hook 'before-save-hook 'time-stamp)
> > This patch adds the recommended form to `safe-local-eval-forms' as well:
>
> Feel free to install this patch, thanks,

I went ahead and installed.

--- End Message ---
<Prev in Thread] Current Thread [Next in Thread>
  • bug#4554: marked as done (local variable for updating the time stamp on save), Emacs bug Tracking System <=