|
|
On Fri, Oct 17 2008, Frank Schmitt wrote:
> Reiner Steib <reinersteib+gmane@xxxxxxx> writes:
>
>> On Fri, Oct 17 2008, Stefan Monnier wrote:
>>
>>>> ;; BEWARE: we used to use string-as-multibyte here which is braindead
>>>> ;; because it will turn accidental emacs-mule-valid byte sequences
>>>> ;; into multibyte chars. --Stef
>>>> ;; Reverted, braindead got 7.5 out of 10 on imdb, so it can't be
>>>> ;; that bad. --Simon
Simon, could you please clarify why you reverted Stefan's change in
`nnimap-demule'? It breaks reading UTF-8 articles via nnimap.el in
Emacs 23.
>>> Who's this Simon who reverted my change without even explaining why?
>>
>> The one who's listed as the author of nnimap.el (cc-ed).
>>
>>>> which is called at several places. And this breaks it. If I change
>>>> this function so that string is not changed, my mails are displayed
>>>> correctly.
>>
>> Does it work correctly when using Stefan's version?
>> ( s/string-as-multibyte/string-to-multibyte/ ...)
>>
>> (defun nnimap-demule (string)
>> ;; BEWARE: we used to use string-as-multibyte here which is braindead
>> ;; because it will turn accidental emacs-mule-valid byte sequences
>> ;; into multibyte chars. --Stef
>> (funcall (if (and (fboundp 'string-to-multibyte)
>> (subrp (symbol-function 'string-to-multibyte)))
>> 'string-to-multibyte
>> 'identity)
>> (or string "")))
>
> Yes, it does.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
|
|