Re: Links / binserver related bugs in cfengine 2.1.19

[Jason Lander <jason@xxxxxxxxxxxxxxx>]

Mark,

> The list broke at the wrong time so you obviously didn't get the
> message. There has been a patch almost since the release. I apologize.
> These things happen. This was a very odd problem.

Cfengine has saved me a great deal of time and grief over the years.  I'm
not going to let a few bugs and a misbehaving mailing list put me off...

Incidentally, I think the bug related to freeing memory which will be
used later is still present in 2.1.19p1 and in the subversion repositry.

   nameinfo.c
   148 VDEFAULTBINSERVER.name = sp;     // should this be strdup(sp)?
   149
   150 AddClassToHeap(CanonifyName(sp));
   151
   152 free(sp); /* Release the ressource */

This bug doesn't get much exercise. In the majority of cases, the freed
memory at sp isn't overwritten before VDEFAULTBINSERVER.name is used.

- Jason