gcc-patches@gcc.gnu.org
[Top] [All Lists]

Fix ACX_LARGEFILE to use canonical host/target names

Subject: Fix ACX_LARGEFILE to use canonical host/target names
From: "Joseph S. Myers"
Date: Fri, 20 Nov 2009 22:38:16 +0000 UTC
The ACX_LARGEFILE macro checks the values of $host and $target, which
may or may not be canonical names at this point depending on which
other macros have been called first; it should require
AC_CANONICAL_HOST and AC_CANONICAL_TARGET to ensure they are both
canonical.  This shows up as build failures for GDB configured
--build=i686-pc-linux-gnu --host=i686-solaris2.10
--target=i686-solaris2.10.  OK to commit this patch (GCC and src),
with regeneration of the GDB and binutils configure scripts that use
ACX_LARGEFILE?

2009-11-20  Joseph Myers  <joseph@xxxxxxxxxxxxxxxx>

        * largefile.m4 (ACX_LARGEFILE): Require AC_CANONICAL_HOST and
        AC_CANONICAL_TARGET.

Index: config/largefile.m4
===================================================================
RCS file: /cvs/src/src/config/largefile.m4,v
retrieving revision 1.2
diff -u -r1.2 largefile.m4
--- config/largefile.m4 9 Nov 2009 23:19:11 -0000       1.2
+++ config/largefile.m4 20 Nov 2009 22:33:02 -0000
@@ -5,6 +5,11 @@
 
 AC_DEFUN([ACX_LARGEFILE],[dnl
 
+# The tests for host and target for $enable_largefile require
+# canonical names.
+AC_REQUIRE([AC_CANONICAL_HOST])
+AC_REQUIRE([AC_CANONICAL_TARGET])
+
 # As the $enable_largefile decision depends on --enable-plugins we must set it
 # even in directories otherwise not depending on the $plugins option.
 

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>