|
|
2009/11/3 Joseph S. Myers <joseph@xxxxxxxxxxxxxxxx>:
> On Tue, 3 Nov 2009, Kai Tietz wrote:
>
>> Hello,
>>
>> the current implementation of the push_macro/pop_macro feature for
>> windows targets was broken for C++ frontend and preprocessor. Just for
>> C it was working proper. So I would like to move this feature from C
>> frontend into libcpp as internal support pragma for all targets.
>
> I don't see a testcase added to the testsuite by the patch. You need to
> add at least one that fails before and passes after the patch, unless
> there is already one there.
>
> (This is not a review of the rest of the patch.)
>
> --
> Joseph S. Myers
> joseph@xxxxxxxxxxxxxxxx
>
Ok. Revised version with additional testcase.
2009-11-03 Kai Tietz <kai.tietz@xxxxxxxxxxxxx>
* gcc.c-torture/execute/pushpop_macro.c: New testcase.
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
|
|