>>>>> "Kai" == Kai Tietz <ktietz70@xxxxxxxxxxxxxx> writes:
Tom> I would prefer that all new errors pass an explicit location.
Tom> This occurs a couple of times.
Kai> This is didn't got. What you mean here about explicit location? You
Kai> mean special messages for syntactical errors here?
What I meant is, for a new error, use the cpp_error_with_line function
and pass in the proper location explicitly. Sometimes (I didn't check
this code) this is not easy, in which case it is ok to skip it.
Kai> -/* Like lex_macro_node, but read the input from STR. */
Kai> -static cpp_hashnode *
Kai> -lex_macro_node_from_str (cpp_reader *pfile, const char *str)
What is the rationale for this part of the change?
Kai> -static GTY((param_is (struct def_pragma_macro))) htab_t
Do pushed macros work properly with PCH after this patch?
This is looking pretty good.