Re: [PATCH] Attribute noclone

Subject:	Re: [PATCH] Attribute noclone
From:	Richard Henderson
Date:	Fri, 24 Jul 2009 07:30:39 -0700

On 07/24/2009 05:44 AM, Martin Jambor wrote:

-  return copy_forbidden (DECL_STRUCT_FUNCTION (fndecl), fndecl) == NULL;
+  return (copy_forbidden (DECL_STRUCT_FUNCTION (fndecl), fndecl) == NULL)
+&&  !lookup_attribute ("noclone", DECL_ATTRIBUTES (fndecl));


Misplaced ().  Should be

  return (!lookup_attribute (...)
          && copy_forbidden (...));

Ok with that change.


r~

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] Attribute noclone, (continued) Re: [PATCH] Attribute noclone, Richard Henderson Re: [PATCH] Attribute noclone, Chris Lattner Re: [PATCH] Attribute noclone, Martin Jambor Re: [PATCH] Attribute noclone, Martin Jambor Re: [PATCH] Attribute noclone, Richard Guenther Re: [PATCH] Attribute noclone, Jan Hubicka Re: [PATCH] Attribute noclone, Richard Henderson Re: [PATCH] Attribute noclone, Richard Guenther Re: [PATCH] Attribute noclone, Richard Henderson Re: [PATCH] Attribute noclone, Paolo Bonzini Re: [PATCH] Attribute noclone, Richard Henderson <= Re: [PATCH] Attribute noclone, Martin Jambor

Previous by Date:	Re: [PATCH] emit_store_flag: Use recursive call for the xor case, Michael Meissner
Next by Date:	Re: [PATCH] Attribute noclone, Jan Hubicka
Previous by Thread:	Re: [PATCH] Attribute noclone, Paolo Bonzini
Next by Thread:	Re: [PATCH] Attribute noclone, Martin Jambor
Indexes:	[Date] [Thread] [Top] [All Lists]