| Subject: | Re: [PATCH] Fix reload failures on inline asm from mplayer SVN PR rtl-optimization/39543 |
|---|---|
| From: | Paolo Bonzini |
| Date: | Thu, 26 Mar 2009 19:26:07 +0100 |
>> +{
>> + int *regnop = (int *) data;
>> +
>> + if (!REG_P (*px))
>> + return 0;
>> +
>> + if (*regnop < 0 || *regnop == (int) REGNO (*px))
>
> Eh, when can you have *regnop < 0?
Here...
>> + /* In __asm don't replace if src might need more registers than
>> + reg, as that could increase register pressure on the __asm. */
>> + regno = -1;
... on the first call.
Using a DF_INSN_USES loop without a callback will make it easier to
understand.
> All for_each_rtx and
> note_stores should die in places where the DF cache can use :-)
Add it to the Partial transitions page please!!!
Paolo
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Fix for PR/39548, Xinliang David Li |
|---|---|
| Next by Date: | Re: Patch for PR39557, Xinliang David Li |
| Previous by Thread: | RE: [PATCH] Fix reload failures on inline asm from mplayer SVN (PR rtl-optimization/39543), Steven Bosscher |
| Next by Thread: | [PATCH] Fix reload failures on inline asm from mplayer SVN (PR rtl-optimization/39543, take 2), Jakub Jelinek |
| Indexes: | [Date] [Thread] [Top] [All Lists] |