gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: [patch i386]: PR/39356 name collision of __chkstk

Subject: Re: [patch i386]: PR/39356 name collision of __chkstk
From: Dave Korn
Date: Thu, 19 Mar 2009 15:59:47 +0000
Kai Tietz wrote:
> Hello,
> 
> this patch fixes PR/39356 (
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39356)

  Hi Kai, just a minor nit:

-       .global ___chkstk
-       .global __alloca
+.global ___gnu_chkstk
+.global        __alloca
 #ifndef _WIN64
+.global ___chkstk


  Please retain the existing formatting convention for indenting pseudo-ops.
I'm guessing this is just accidental, since the earlier version of your patch
in the PR didn't do this.

    cheers,
      DaveK

<Prev in Thread] Current Thread [Next in Thread>